-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix restoration of infra with migrated network layout #907
Open
plkokanov
wants to merge
3
commits into
gardener:master
Choose a base branch
from
plkokanov:fix/migrate-infrastructure
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
Needs review
area/control-plane-migration
Control plane migration related
kind/bug
Bug
platform/azure
Microsoft Azure platform/infrastructure
needs/rebase
Needs git rebase
labels
Jun 27, 2024
@plkokanov You need rebase this pull request with latest master branch. Please check. |
gardener-robot-ci-1
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Jun 27, 2024
gardener-robot
added
the
size/m
Size of pull request is medium (see gardener-robot robot/bots/size.py)
label
Jun 27, 2024
gardener-robot-ci-1
added
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Jun 27, 2024
plkokanov
force-pushed
the
fix/migrate-infrastructure
branch
from
June 27, 2024 09:12
8143a4d
to
e149789
Compare
gardener-robot-ci-3
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Jun 27, 2024
gardener-robot-ci-3
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Jun 27, 2024
/hold |
gardener-robot
added
the
reviewed/do-not-merge
Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies
label
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/control-plane-migration
Control plane migration related
kind/bug
Bug
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
needs/rebase
Needs git rebase
needs/review
Needs review
platform/azure
Microsoft Azure platform/infrastructure
reviewed/do-not-merge
Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies
size/m
Size of pull request is medium (see gardener-robot robot/bots/size.py)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane-migration
/kind bug
/platform azure
What this PR does / why we need it:
This PR modifies the layout mutator which adds the
migration.azure.provider.extensions.gardener.cloud/zone
annotation on theInfrastructure
resource so that the annotation is also added during therestore
phase of control plane migration in the following cases:.status.state
field is defined and is in theazure.provider.extensions.gardener.cloud/v1alpha1
group version, then.data
field contains an entry formigration.azure.provider.extensions.gardener.cloud/zone
, then this entry is added as an annotation to theInfrastructure
resource.status.state
field is defined and its type isInfrastructureState
, then.state
field contains a.savedProviderStatus
field and its.networks.subnets
array contains a subnet for which the.migrated
field is true and the.zone
field is not nilAdditionally, during reconciliation, if the new flow reconciler is used and the
migration.azure.provider.extensions.gardener.cloud/zone
annotation is present on theInfrastructure
resource, then it is persisted in the.status.state.data
map.Which issue(s) this PR fixes:
Fixes #827
Special notes for your reviewer:
Release note: