Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendor gardener/gardener@v1.91.1, Upgrade k8s.io/* dependencies and controller-runtime #814

Merged
merged 6 commits into from
Apr 4, 2024
Merged

Vendor gardener/gardener@v1.91.1, Upgrade k8s.io/* dependencies and controller-runtime #814

merged 6 commits into from
Apr 4, 2024

Conversation

hebelsan
Copy link
Contributor

How to categorize this PR?

/area open-source
/kind enhancement
/platform azure

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

The following golang dependencies have been upgraded :
- `gardener/gardener`: `v1.87.0`->`v1.91.1`
- k8s.io/* : v0.28.3 -> v0.29.3
- sigs.k8s.io/controller-runtime: v0.16.3-> v0.17.2
- sigs.k8s.io/controller-tools v0.13.0-> v0.14.0

@hebelsan hebelsan requested review from a team as code owners March 28, 2024 08:37
@gardener-robot gardener-robot added needs/review Needs review area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension platform/azure Microsoft Azure platform/infrastructure labels Mar 28, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 28, 2024
@gardener-robot gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Mar 28, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 28, 2024
shafeeqes
shafeeqes reviewed Mar 28, 2024
View reviewed changes
pkg/controller/infrastructure/terraform_reconciler_test.go Outdated
@@ -332,8 +332,8 @@ var _ = Describe("Actuator", func() {
It("should restore infrastructure with countFault and countUpdate domain values found in ProviderStatus if availability set is required", func() {
providerStatus.AvailabilitySets = append(providerStatus.AvailabilitySets, apiv1alpha1.AvailabilitySet{
Purpose: apiv1alpha1.PurposeNodes,
CountFaultDomains: pointer.Int32(6),
CountUpdateDomains: pointer.Int32(7),
CountFaultDomains: ptr.To(int32(6)),
Copy link
Contributor

@shafeeqes shafeeqes Mar 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use ptr.To[int32]()

@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 28, 2024
@hebelsan
Copy link
Contributor Author

Updated golang image master, 53514cc1

@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 28, 2024
@hebelsan hebelsan added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 28, 2024
@shafeeqes
Copy link
Contributor

Can you also add KnownCodes to the infra reconciler, similar to gardener/gardener-extension-provider-aws@76d1610?

@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 2, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 4, 2024
@hebelsan
Copy link
Contributor Author

hebelsan commented Apr 4, 2024

/test

@testmachinery
Copy link

testmachinery bot commented Apr 4, 2024 •
edited
Loading

Testrun: e2e-xcnc8
Workflow: e2e-xcnc8-wf
Phase: Succeeded

+---------------------+---------------------------+-----------+----------+
|        NAME         |           STEP            |   PHASE   | DURATION |
+---------------------+---------------------------+-----------+----------+
| bastion-test        | bastion-test              | Succeeded | 12m8s    |
| infrastructure-test | infrastructure-test       | Succeeded | 30m3s    |
| infrastructure-test | infra-flow-test           | Succeeded | 26m34s   |
| infrastructure-test | infra-flow-migration-test | Succeeded | 31m45s   |
+---------------------+---------------------------+-----------+----------+

kon-angelo
kon-angelo approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Apr 4, 2024
@kon-angelo kon-angelo merged commit 8e4be84 into gardener:master Apr 4, 2024
13 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Apr 4, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 4, 2024
@hebelsan hebelsan deleted the update-gardener-1.91.1 branch April 4, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shafeeqes shafeeqes shafeeqes left review comments

@kon-angelo kon-angelo kon-angelo approved these changes

Assignees
No one assigned
Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/azure Microsoft Azure platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hebelsan @shafeeqes @kon-angelo @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot