Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/gardener/external-dns-management from 0.18.4 to 0.18.5 #926

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

MartinWeindel
Copy link
Member

How to categorize this PR?

/area control-plane
/kind bug
/platform aws

What this PR does / why we need it:
Bump github.com/gardener/external-dns-management from 0.18.4 to 0.18.5.

This includes the fix from PR gardener/external-dns-management#365 which excludes "us-gov" domains from ALIAS DNS record creation. As the package github.com/gardener/external-dns-management/pkg/controller/provider/aws/data is reused in the Route53 client, the "us-gov" alias fix applies automatically with this PR.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Bump github.com/gardener/external-dns-management from 0.18.4 to 0.18.5.
DNSRecord controller will not create ALIAS DNS records for AWS "us-gov" zones anymore.

@MartinWeindel MartinWeindel requested review from a team as code owners April 19, 2024 15:01
@gardener-robot gardener-robot added needs/review Needs review area/control-plane Control plane related kind/bug Bug platform/aws Amazon web services platform/infrastructure size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Apr 19, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 19, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 19, 2024
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Apr 19, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 19, 2024
@kon-angelo kon-angelo merged commit ddf6c56 into master Apr 19, 2024
18 checks passed
@kon-angelo kon-angelo deleted the dnsman-v0.18.5 branch April 19, 2024 15:26
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane Control plane related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/aws Amazon web services platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants