-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce InfrastructureConfigFromCluster
and use it instead of API call
#1068
Introduce InfrastructureConfigFromCluster
and use it instead of API call
#1068
Conversation
@Kostov6 Label area/bug does not exist. |
f2381ba
to
eec15e7
Compare
InfrastructureConfigFromCluster
and use it instead of api callInfrastructureFromCluster
and use it instead of api call
eec15e7
to
b1e406f
Compare
InfrastructureFromCluster
and use it instead of api callInfrastructureConfigFromCluster
and use it instead of api call
InfrastructureConfigFromCluster
and use it instead of api callInfrastructureConfigFromCluster
and use it instead of API call
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
@Kostov6 You need rebase this pull request with latest master branch. Please check. |
b1e406f
to
ea73612
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@Kostov6 when you rebased the PR, you reverted the fixes for #1068 (comment) that I pushed 🙈 . See #1086 |
How to categorize this PR?
/area quality
/kind bug
/platform aws
What this PR does / why we need it:
This PR introduces
InfrastructureConfigFromCluster
that extracts the infrastructureConfig from a cluster resource and uses it inpkg/webhook/controlplane/ensurer.go
instead of an API call.Which issue(s) this PR fixes:
This fixes a issue where cluster force deletion may fail
Special notes for your reviewer:
Release note: