-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEP-25] Enable Shoot cloudProfile reference as complement to cloudProfileName #1000
Merged
kon-angelo
merged 1 commit into
gardener:master
from
LucaBernstein:gep-25-namespacedcloudprofiles
Oct 16, 2024
Merged
[GEP-25] Enable Shoot cloudProfile reference as complement to cloudProfileName #1000
kon-angelo
merged 1 commit into
gardener:master
from
LucaBernstein:gep-25-namespacedcloudprofiles
Oct 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
Needs review
area/open-source
Open Source (community, enablement, contributions, conferences, CNCF, etc.) related
area/usability
Usability related
kind/api-change
API change with impact on API users
kind/enhancement
Enhancement, improvement, extension
platform/aws
Amazon web services platform/infrastructure
reviewed/do-not-merge
Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies
size/l
Size of pull request is large (see gardener-robot robot/bots/size.py)
needs/second-opinion
Needs second review by someone else
labels
Jul 12, 2024
gardener-robot-ci-1
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Jul 12, 2024
gardener-robot-ci-2
added
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Jul 12, 2024
LucaBernstein
force-pushed
the
gep-25-namespacedcloudprofiles
branch
from
July 15, 2024 07:11
508e976
to
072474d
Compare
gardener-robot-ci-1
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Jul 15, 2024
LucaBernstein
force-pushed
the
gep-25-namespacedcloudprofiles
branch
from
July 15, 2024 07:46
072474d
to
38f64b7
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Jul 15, 2024
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Jul 15, 2024
36 tasks
LucaBernstein
force-pushed
the
gep-25-namespacedcloudprofiles
branch
from
July 22, 2024 13:51
38f64b7
to
1b7c968
Compare
gardener-robot
added
size/m
Size of pull request is medium (see gardener-robot robot/bots/size.py)
and removed
size/l
Size of pull request is large (see gardener-robot robot/bots/size.py)
labels
Jul 22, 2024
gardener-robot-ci-2
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Jul 22, 2024
LucaBernstein
force-pushed
the
gep-25-namespacedcloudprofiles
branch
from
July 22, 2024 13:53
1b7c968
to
238f25f
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Jul 22, 2024
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Jul 22, 2024
LucaBernstein
force-pushed
the
gep-25-namespacedcloudprofiles
branch
from
July 26, 2024 09:49
238f25f
to
8ad54fa
Compare
LucaBernstein
force-pushed
the
gep-25-namespacedcloudprofiles
branch
from
August 13, 2024 08:16
21a1f9e
to
cf8b3e7
Compare
gardener-robot-ci-2
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Aug 13, 2024
LucaBernstein
force-pushed
the
gep-25-namespacedcloudprofiles
branch
from
August 13, 2024 13:19
cf8b3e7
to
4e1e127
Compare
gardener-robot
added
the
size/xl
Size of pull request is huge (see gardener-robot robot/bots/size.py)
label
Aug 13, 2024
gardener-robot-ci-3
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Aug 13, 2024
gardener-robot
removed
the
size/l
Size of pull request is large (see gardener-robot robot/bots/size.py)
label
Aug 13, 2024
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Aug 13, 2024
LucaBernstein
force-pushed
the
gep-25-namespacedcloudprofiles
branch
from
August 13, 2024 13:22
4e1e127
to
29fc5b8
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Aug 13, 2024
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Aug 13, 2024
LucaBernstein
force-pushed
the
gep-25-namespacedcloudprofiles
branch
from
September 12, 2024 15:01
29fc5b8
to
8482948
Compare
gardener-robot
added
the
size/m
Size of pull request is medium (see gardener-robot robot/bots/size.py)
label
Sep 12, 2024
gardener-robot-ci-2
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Sep 12, 2024
gardener-robot
removed
the
size/xl
Size of pull request is huge (see gardener-robot robot/bots/size.py)
label
Sep 12, 2024
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Sep 12, 2024
Switch from CloudProfile to CloudProfileSpec as a generic foundation for CloudProfile and NamespacedCloudProfile. Improve log message for possibly artificially crafted CloudProfile from NamespacedCloudProfile in Cluster resource.
LucaBernstein
force-pushed
the
gep-25-namespacedcloudprofiles
branch
from
September 13, 2024 09:34
8482948
to
7ebf72a
Compare
gardener-robot-ci-3
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Sep 13, 2024
kon-angelo
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
gardener-robot
added
reviewed/lgtm
Has approval for merging
and removed
needs/review
Needs review
needs/second-opinion
Needs second review by someone else
labels
Sep 26, 2024
gardener-robot-ci-3
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Sep 26, 2024
LucaBernstein
removed
the
reviewed/do-not-merge
Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies
label
Sep 26, 2024
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Sep 26, 2024
gardener-robot
added
the
status/closed
Issue is closed (either delivered or triaged)
label
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/open-source
Open Source (community, enablement, contributions, conferences, CNCF, etc.) related
area/usability
Usability related
kind/api-change
API change with impact on API users
kind/enhancement
Enhancement, improvement, extension
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
platform/aws
Amazon web services platform/infrastructure
reviewed/lgtm
Has approval for merging
size/m
Size of pull request is medium (see gardener-robot robot/bots/size.py)
status/closed
Issue is closed (either delivered or triaged)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area open-source
/area usability
/kind api-change
/kind enhancement
/platform aws
What this PR does / why we need it:
Make the aws provider extension aware of the
CloudProfile
field and the option to provideNamespacedCloudProfile
references in theshoot.Spec.CloudProfile
.See also GEP-25 and this PR.
Which issue(s) this PR fixes:
Related to gardener/gardener#9504
Special notes for your reviewer:
Release note: