Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move providerID flag to configuration file of kubelet #460

Merged
merged 4 commits into from
Mar 14, 2022
Merged

move providerID flag to configuration file of kubelet #460

merged 4 commits into from
Mar 14, 2022

Conversation

shaoyongfeng
Copy link
Contributor

@shaoyongfeng shaoyongfeng commented Mar 11, 2022 •
edited
Loading

How to categorize this PR?
/area control-plane
/kind enhancement
/platform alicloud

What this PR does / why we need it:
since 1.23 version providerid flag of kubelet is deprecated and we need move it to configuration file
Which issue(s) this PR fixes:
Fixes #202

Special notes for your reviewer:
I test following scenarios

  1. create shoot using k8s <1.23
  2. create shoot using k8s = 1.23
  3. upgrade k8s version of first shoot to 1.23

Release note:

@shaoyongfeng shaoyongfeng requested review from a team as code owners March 11, 2022 06:56
@gardener-robot gardener-robot added area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension platform/alicloud Alicloud platform/infrastructure labels Mar 11, 2022
@gardener-robot
Copy link

@shaoyongfeng Thank you for your contribution.

@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Mar 11, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 11, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 11, 2022
rfranzke
rfranzke reviewed Mar 11, 2022
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up!
Please add a unit test

@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 11, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 11, 2022
@jia-jerry jia-jerry added this to the v1.34 milestone Mar 11, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 14, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 14, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 14, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 14, 2022
jia-jerry
jia-jerry approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@jia-jerry jia-jerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Mar 14, 2022
@shaoyongfeng shaoyongfeng merged commit 11c81b3 into gardener:master Mar 14, 2022
@shaoyongfeng shaoyongfeng deleted the issue-202 branch March 14, 2022 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke left review comments

@jia-jerry jia-jerry jia-jerry approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/alicloud Alicloud platform/infrastructure reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.

cloud provider configuration will be deprecated for kubelet prameters
7 participants
@shaoyongfeng @gardener-robot @rfranzke @jia-jerry @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3