Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix empty targets #52

Merged
merged 1 commit into from
Jan 14, 2020
Merged

fix empty targets #52

merged 1 commit into from
Jan 14, 2020

Conversation

MartinWeindel
Copy link
Member

What this PR does / why we need it:
Invalid DNSEntries with empty target should not be forwarded to the provider.

Which issue(s) this PR fixes:
Fixes #51

Special notes for your reviewer:

Release note:

DNS entry with empty target is recognised as invalid.

Co-authored-by: Uwe Krueger <uwe.krueger@sap.com>
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 14, 2020
@MartinWeindel MartinWeindel merged commit 990b21b into master Jan 14, 2020
@MartinWeindel MartinWeindel deleted the fix-empty-target branch January 14, 2020 14:31
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty target breaks the controller
2 participants