dnssources: ignore empty targets for slave entries on update #357
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If an ingress controller is updated, its load balancer may be recreated. As a consequence, all related ingress resources lose their
.status.loadBalancer
values and their DNS entries are deleted temporarily.To avoid such "hickups", on updating DNS entries for a DNS source object, an empty target list is ignored and the old targets are just kept until new targets (e.g. loadbalancer addresses) are set.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: