Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnssources: ignore empty targets for slave entries on update #357

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

MartinWeindel
Copy link
Member

What this PR does / why we need it:
If an ingress controller is updated, its load balancer may be recreated. As a consequence, all related ingress resources lose their .status.loadBalancer values and their DNS entries are deleted temporarily.
To avoid such "hickups", on updating DNS entries for a DNS source object, an empty target list is ignored and the old targets are just kept until new targets (e.g. loadbalancer addresses) are set.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Ignore empty targets for slave entries on update. More concretely, if an ingress resource lose their load balancer addresses during an update, the old targets are kept until new targets are set.

@MartinWeindel MartinWeindel requested a review from a team as a code owner February 22, 2024 08:41
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Feb 22, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 22, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 22, 2024
@MartinWeindel MartinWeindel merged commit ed06633 into master Feb 22, 2024
8 checks passed
@MartinWeindel MartinWeindel deleted the dnssource-ignore-empty-targets branch February 22, 2024 09:35
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants