Drop retrieval of forwarded domains to avoid synching unused hosted zones #336
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The providers do not read anymore all accessible hosted zone to find forwarded subdomains defined by
NS
record sets, i.e. subdomains which have another authoritative nameserver. Only forwarded subdomains known by the domain names of accessible hosted zones will be used to select the correct zone for the domain of aDNSEntry
.This means if there is a
NS
record set for a subdomain of a hosted zone which is hosted by a foreign nameserver, the DNS records for theDNSEntry
will still be created in the accessible hosted zone. In this case, a lookup via a public DNS server will not return these newly created DNS records. Before this change, theDNSEntry
would have shown an error state, as it could not find a suitableDNSProvider
.Example for the changed behaviour:
Let's assume the credentials for a provider allows accessing three public zones:
zone1.example.com
,zone2.example.com
, andzone3.example.com
. The zone1 contains aNS
record forfoo.bar.zone1.example.com
which is hosted on a foreign authoritative nameserver. There is only aDNSProvider
including the domainbar.zone1.example.com
. The dns-controller-manager finds the correct zonezone1.example.com
. With the new behaviour it only reads the DNS records of zone1. The other zones are ignored as long as noDNSProvider
want to access them. Formerly, also all records of zone2 and zone3 would have been read periodically to know about the forwarded domains.Creating a
DNSEntry
forsvc.foo.bar.zone1.example.com
now results in the creation of a DNS record set in the zonezone1.example.com
, which will not be found if looked up by a public DNS server, as the DNS record set should have to been placed into the forwarded hosted zonefoo.bar.zone1.example.com
. With the former behaviour, applying thisDNSEntry
would have resulted in an error state without action.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: