Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate provider domain includes and excludes for wildcards #335

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

MartinWeindel
Copy link
Member

What this PR does / why we need it:
The DNSProvider specifies included and excluded domain with the spec.domains.include and spec.domains.exclude fields.
It is expected, that these are the plain domain names and subsume any subdomains implicitly.
Sometimes users try to define a domain using wildcards, e.g. *.example.com instead of example.com, which is accepted, but does not work.
With this PR, the include and exclude domains are validated for such forbidden wildcard domains and report a user friendly error.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Validate provider domain includes and excludes for forbidden wildcard domains.

@MartinWeindel MartinWeindel requested a review from a team as a code owner November 22, 2023 10:25
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Nov 22, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 22, 2023
@MartinWeindel MartinWeindel merged commit b939284 into master Nov 22, 2023
1 check passed
@MartinWeindel MartinWeindel deleted the enh/validate-domains-for-wildcards branch November 22, 2023 13:51
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants