Validate provider domain includes and excludes for wildcards #335
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The
DNSProvider
specifies included and excluded domain with thespec.domains.include
andspec.domains.exclude
fields.It is expected, that these are the plain domain names and subsume any subdomains implicitly.
Sometimes users try to define a domain using wildcards, e.g.
*.example.com
instead ofexample.com
, which is accepted, but does not work.With this PR, the include and exclude domains are validated for such forbidden wildcard domains and report a user friendly error.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: