[GEP-17] Add owner checks and taking of final snapshots #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
|
Still in Draft because it depends on #369 but I would really appreciate early feedback if you have time. |
stoyanr
force-pushed
the
cpm/add-owner-check
branch
from
cfa49c8
to
f930f67
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
stoyanr
force-pushed
the
cpm/add-owner-check
branch
from
f930f67
to
4bf6b02
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
|
Rebased on latest master and removed Draft. |
|
/assign |
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
stoyanr
force-pushed
the
cpm/add-owner-check
branch
from
987c103
to
836b838
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
stoyanr
force-pushed
the
cpm/add-owner-check
branch
from
836b838
to
654d96d
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
stoyanr
force-pushed
the
cpm/add-owner-check
branch
from
654d96d
to
c606c87
Compare
gardener-robot-ci-3
added
reviewed/ok-to-test
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
|
@ishan16696 Addressed your latest feedback with a new commit. Also added a new commit to make sure the owner checks are disabled (and not simply always succeeding), if the owner name or id are not specified. |
timuthy
reviewed
Oct 14, 2021
There was a problem hiding this comment.
Even though I haven't completely reviewed this PR, I already want to address one topic that has drawn my attention while reviewing gardener/etcd-druid#239.
gardener-robot-ci-3
added
reviewed/ok-to-test
46 tasks
shreyas-s-rao
requested changes
Oct 19, 2021
There was a problem hiding this comment.
@stoyanr Thanks for the well-written PR! I have a few doubts/suggestions. Can you please address them? Thanks
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
shreyas-s-rao
approved these changes
Oct 20, 2021
timuthy
suggested changes
Oct 20, 2021
gardener-robot-ci-1
added
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds functionality to check if the owner domain name resolves to the specified owner ID and if not, take a final full snapshot and disable the cluster, as described in GEP-17.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: