Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add publish-test-images job to the registry-cache extension #970

Conversation

ialidzhikov
Copy link
Member

What this PR does / why we need it:
This PR adds publish-test-images job to the registry-cache extension.
The final goal is extension developer to be able to publish images from PR by running /test pull-gardener-extension-registry-cache-publish-test-images

Which issue(s) this PR fixes:
Part of gardener/gardener-extension-registry-cache#3

Special notes for your reviewer:
N/A

@gardener-prow gardener-prow bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Oct 24, 2023
@gardener-prow gardener-prow bot requested review from ary1992 and shafeeqes October 24, 2023 08:43
@gardener-prow gardener-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 24, 2023
@ialidzhikov
Copy link
Member Author

/kind enhancement

@gardener-prow gardener-prow bot added kind/enhancement Enhancement, improvement, extension and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 24, 2023
@oliver-goetz
Copy link
Member

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2023
@gardener-prow
Copy link

gardener-prow bot commented Oct 24, 2023

LGTM label has been added.

Git tree hash: ab179a25d04168ce006a46c3efaea934ae9a6f35

@gardener-prow
Copy link

gardener-prow bot commented Oct 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oliver-goetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2023
@gardener-prow gardener-prow bot merged commit ec12c15 into gardener:master Oct 24, 2023
@gardener-prow
Copy link

gardener-prow bot commented Oct 24, 2023

@ialidzhikov: Updated the job-config configmap in namespace prow at cluster gardener-prow-trusted using the following files:

  • key gardener-extension-registry-cache-test-builds.yaml using file config/jobs/gardener-extension-registry-cache/gardener-extension-registry-cache-test-builds.yaml

In response to this:

What this PR does / why we need it:
This PR adds publish-test-images job to the registry-cache extension.
The final goal is extension developer to be able to publish images from PR by running /test pull-gardener-extension-registry-cache-publish-test-images

Which issue(s) this PR fixes:
Part of gardener/gardener-extension-registry-cache#3

Special notes for your reviewer:
N/A

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ialidzhikov ialidzhikov deleted the enh/registry-cache-publish-test-images branch October 25, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants