Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e tests for registry-cache pull requests #847

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Add e2e tests for registry-cache pull requests #847

merged 1 commit into from
Aug 31, 2023

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented Aug 18, 2023 •
edited
Loading

/kind enhancement

What this PR does / why we need it:
This PR adds a presubmit job that runs e2e tests for the registry-cache extension.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
Draft until gardener/gardener-extension-registry-cache#30 is merged.

@gardener-prow
Copy link

gardener-prow bot commented Aug 18, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-prow gardener-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 18, 2023
@gardener-prow gardener-prow bot requested review from timebertt and timuthy August 18, 2023 06:40
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 18, 2023
@ialidzhikov
Copy link
Member Author

/kind enhancement

@gardener-prow gardener-prow bot added kind/enhancement Enhancement, improvement, extension and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Aug 18, 2023
@ialidzhikov ialidzhikov mentioned this pull request Aug 18, 2023
Closed
96 tasks
@ialidzhikov ialidzhikov force-pushed the enh/registry-cache-e2e-tests branch from 0c0842f to 0c27316 Compare August 30, 2023 14:27
@ialidzhikov
Copy link
Member Author

gardener/gardener-extension-registry-cache#30 is now merged. Promoting the PR to ready for review.

@ialidzhikov ialidzhikov marked this pull request as ready for review August 30, 2023 14:29
@gardener-prow gardener-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 30, 2023
@gardener-prow gardener-prow bot requested a review from oliver-goetz August 30, 2023 14:29
@ialidzhikov ialidzhikov force-pushed the enh/registry-cache-e2e-tests branch from 0c27316 to 267b4c8 Compare August 30, 2023 15:00
dimitar-kostadinov
dimitar-kostadinov reviewed Aug 31, 2023
View reviewed changes
Copy link
Contributor

@dimitar-kostadinov dimitar-kostadinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2023
@gardener-prow
Copy link

gardener-prow bot commented Aug 31, 2023

LGTM label has been added.

Git tree hash: 58bcca3de2adbb346b051fc5ee419c67fa1fe8da

@ialidzhikov
Copy link
Member Author

/approve

@gardener-prow
Copy link

gardener-prow bot commented Aug 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2023
@gardener-prow gardener-prow bot merged commit 962f218 into gardener:master Aug 31, 2023
@gardener-prow
Copy link

gardener-prow bot commented Aug 31, 2023

@ialidzhikov: Updated the job-config configmap in namespace prow at cluster gardener-prow-trusted using the following files:

  • key gardener-extension-registry-cache-e2e-kind.yaml using file config/jobs/gardener-extension-registry-cache/gardener-extension-registry-cache-e2e-kind.yaml

In response to this:

/kind enhancement

What this PR does / why we need it:
This PR adds a presubmit job that runs e2e tests for the registry-cache extension.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
Draft until gardener/gardener-extension-registry-cache#30 is merged.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitar-kostadinov dimitar-kostadinov dimitar-kostadinov left review comments

@timebertt timebertt Awaiting requested review from timebertt

@timuthy timuthy Awaiting requested review from timuthy

@oliver-goetz oliver-goetz Awaiting requested review from oliver-goetz

Assignees

@dimitar-kostadinov dimitar-kostadinov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ialidzhikov @oliver-goetz @dimitar-kostadinov