Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copy images job #640

Merged
merged 3 commits into from
Mar 22, 2023
Merged

Conversation

timebertt
Copy link
Member

What this PR does / why we need it:

Previously, the copy-images job failed to copy one of the configured images: https://prow.gardener.cloud/view/gs/gardener-prow/logs/post-ci-infra-copy-images/1638492793884119040
This PR

  • fixes the configuration (images.yaml)
  • makes the job fail if a single operation fails
  • highlights the Error: log lines

Which issue(s) this PR fixes:
Part of #619

@gardener-prow gardener-prow bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Mar 22, 2023
@gardener-prow gardener-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 22, 2023
@timebertt
Copy link
Member Author

/kind bug

@gardener-prow gardener-prow bot added kind/bug Bug and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 22, 2023
@oliver-goetz
Copy link
Member

/kind enhancement
/approve
/lgtm

@gardener-prow gardener-prow bot added kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. labels Mar 22, 2023
@gardener-prow
Copy link

gardener-prow bot commented Mar 22, 2023

LGTM label has been added.

Git tree hash: 9da5e5ead87992c378b1970128acb6118297f436

@gardener-prow
Copy link

gardener-prow bot commented Mar 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oliver-goetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2023
@gardener-prow gardener-prow bot merged commit 99561db into gardener:master Mar 22, 2023
@gardener-prow
Copy link

gardener-prow bot commented Mar 22, 2023

@timebertt: Updated the config configmap in namespace prow at cluster gardener-prow-trusted using the following files:

  • key config.yaml using file config/prow/config.yaml

In response to this:

What this PR does / why we need it:

Previously, the copy-images job failed to copy one of the configured images: https://prow.gardener.cloud/view/gs/gardener-prow/logs/post-ci-infra-copy-images/1638492793884119040
This PR

  • fixes the configuration (images.yaml)
  • makes the job fail if a single operation fails
  • highlights the Error: log lines

Which issue(s) this PR fixes:
Part of #619

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timebertt timebertt deleted the fix-copy-images branch March 22, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/bug Bug kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants