Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration test #111

Merged
merged 6 commits into from
Mar 21, 2022
Merged

Integration test #111

merged 6 commits into from
Mar 21, 2022

Conversation

AxiomSamarth
Copy link

@AxiomSamarth AxiomSamarth commented Jan 18, 2022 •
edited by himanshu-kun
Loading

What this PR does / why we need it:
This PR introduces integration test suite for Gardener cluster autoscaler

Which issue(s) this PR fixes:
Partly Fixes #110

Special notes for your reviewer:

Release note:

Gardener CA now supports basic IT to run locally.

@AxiomSamarth AxiomSamarth self-assigned this Jan 18, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 18, 2022
@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Jan 18, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 18, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 18, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 18, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 25, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 31, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 3, 2022
@AxiomSamarth AxiomSamarth marked this pull request as ready for review February 3, 2022 09:22
@AxiomSamarth AxiomSamarth requested review from hardikdr and a team as code owners February 3, 2022 09:22
@himanshu-kun
Copy link

@AxiomSamarth just wanted to know why is the updating vendor against .. commit is required?

@AxiomSamarth
Copy link
Author

@AxiomSamarth just wanted to know why is the updating vendor against .. commit is required?

If I remember correctly, then I added the ginkgo modules in the go.mod file and ran that vendor script to vendor the Gingko modules. And as we know, the script adds this commit.

@himanshu-kun
Copy link

Okay, yes its added by script. I think a better option would be to add this dependency overrides in go.mod-extra file. I'll do so , could you give me push access to this branch?

@AxiomSamarth
Copy link
Author

Okay, yes its added by script. I think a better option would be to add this dependency overrides in go.mod-extra file. I'll do so , could you give me push access to this branch?

Indeed, ideally go-mod-extra is the right place to add any additional dependencies as the go.mod is overwritten on every execution of the vendor-udpdate.sh. But, there should be some reason why I added it there. I am not able to recall.

Umm, do we have the go.mod-extra file in the latest version of upstream CA?

PS - I will provide the access to this branch.

@himanshu-kun
Copy link

Umm, do we have the go.mod-extra file in the latest version of upstream CA?

no we don't. I think that's why you added it there. I'll see if there comes any difference by updating in go.mod-extra. If not I'll merge this one only.
Thanks for providing the access.

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 18, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 18, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 21, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 21, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 21, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 21, 2022
@himanshu-kun himanshu-kun merged commit 418db31 into gardener:machine-controller-manager-provider Mar 21, 2022
@himanshu-kun himanshu-kun deleted the integration-test branch March 21, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardikdr hardikdr Awaiting requested review from hardikdr

Assignees

@AxiomSamarth AxiomSamarth

Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integration test for Gardener Autoscaler
6 participants
@AxiomSamarth @himanshu-kun @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot