This repository has been archived by the owner on May 26, 2024. It is now read-only.
Vendor github.com/gardener/machine-controller-manager@v0.52.0 #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind enhancement
What this PR does / why we need it:
For the following subtask from the registri-cache backlog:
I had to spin up a K8s
1.30.0-beta.0
Shoot cluster locally because in kubelet@v1.30.0 there are new image pull duration metrics that I want to explore and poc panel based on them.The Shoot reconciliation stuck on the Machine creation because the K8s version that was discovered and later on gets used is
1.30.0-beta.0
. The check in https://github.com/gardener/machine-controller-manager-provider-local/blob/8e34e10d355b95c46996e0e11c20d62889404e78/vendor/github.com/gardener/machine-controller-manager/pkg/util/provider/app/app.go#L268-L272 is failing because the constaint in https://github.com/gardener/machine-controller-manager-provider-local/blob/eb5710f2eacfd75fa2883d63d97a58d7e95163d0/vendor/github.com/gardener/machine-controller-manager/pkg/util/k8sutils/version.go#L33 is not correct (does not ignore version suffixes).Hence the machine-controller-manager-provider-local container is local setup against
1.30.0-beta.0
kube-apiserver fails with:The corresponding constraint is fixed in
machine-controller-manager@v0.51.0
with gardener/machine-controller-manager#882.That's why I decided to vendor github.com/gardener/machine-controller-manager@v0.52.0 to adopt the above-mentioned fix. Along the way I had to bump github.com/gardener/gardener to at least v1.76.0 to make
make revendor
happy.Which issue(s) this PR fixes:
Needed for subtask in gardener/gardener-extension-registry-cache#3
Special notes for your reviewer:
N/A
Release note: