Skip to content
This repository has been archived by the owner on May 26, 2024. It is now read-only.

Vendor github.com/gardener/machine-controller-manager@v0.52.0 #36

Conversation

ialidzhikov
Copy link
Contributor

@ialidzhikov ialidzhikov commented Mar 14, 2024

/kind enhancement

What this PR does / why we need it:
For the following subtask from the registri-cache backlog:

  • Check for kubelet metrics to show a panel about image pull times

I had to spin up a K8s 1.30.0-beta.0 Shoot cluster locally because in kubelet@v1.30.0 there are new image pull duration metrics that I want to explore and poc panel based on them.

The Shoot reconciliation stuck on the Machine creation because the K8s version that was discovered and later on gets used is 1.30.0-beta.0. The check in https://github.com/gardener/machine-controller-manager-provider-local/blob/8e34e10d355b95c46996e0e11c20d62889404e78/vendor/github.com/gardener/machine-controller-manager/pkg/util/provider/app/app.go#L268-L272 is failing because the constaint in https://github.com/gardener/machine-controller-manager-provider-local/blob/eb5710f2eacfd75fa2883d63d97a58d7e95163d0/vendor/github.com/gardener/machine-controller-manager/pkg/util/k8sutils/version.go#L33 is not correct (does not ignore version suffixes).

Hence the machine-controller-manager-provider-local container is local setup against 1.30.0-beta.0 kube-apiserver fails with:

% k -n shoot--local--local logs machine-controller-manager-665f44f855-29xf5 machine-controller-manager-provider-local

E0314 09:46:17.604192       1 reflector.go:140] k8s.io/client-go/informers/factory.go:150: Failed to watch *v1beta1.PodDisruptionBudget: failed to list *v1beta1.PodDisruptionBudget: the server could not find the requested resource
I0314 09:46:41.294132       1 reflector.go:257] Listing and watching *v1beta1.PodDisruptionBudget from k8s.io/client-go/informers/factory.go:150
W0314 09:46:41.295828       1 reflector.go:424] k8s.io/client-go/informers/factory.go:150: failed to list *v1beta1.PodDisruptionBudget: the server could not find the requested resource
E0314 09:46:41.295859       1 reflector.go:140] k8s.io/client-go/informers/factory.go:150: Failed to watch *v1beta1.PodDisruptionBudget: failed to list *v1beta1.PodDisruptionBudget: the server could not find the requested resource
I0314 09:47:11.802060       1 reflector.go:257] Listing and watching *v1beta1.PodDisruptionBudget from k8s.io/client-go/informers/factory.go:150
W0314 09:47:11.804693       1 reflector.go:424] k8s.io/client-go/informers/factory.go:150: failed to list *v1beta1.PodDisruptionBudget: the server could not find the requested resource
E0314 09:47:11.804749       1 reflector.go:140] k8s.io/client-go/informers/factory.go:150: Failed to watch *v1beta1.PodDisruptionBudget: failed to list *v1beta1.PodDisruptionBudget: the server could not find the requested resource
I0314 09:47:47.381257       1 reflector.go:257] Listing and watching *v1beta1.PodDisruptionBudget from k8s.io/client-go/informers/factory.go:150
W0314 09:47:47.383413       1 reflector.go:424] k8s.io/client-go/informers/factory.go:150: failed to list *v1beta1.PodDisruptionBudget: the server could not find the requested resource
E0314 09:47:47.383464       1 reflector.go:140] k8s.io/client-go/informers/factory.go:150: Failed to watch *v1beta1.PodDisruptionBudget: failed to list *v1beta1.PodDisruptionBudget: the server could not find the requested resource

The corresponding constraint is fixed in machine-controller-manager@v0.51.0 with gardener/machine-controller-manager#882.

That's why I decided to vendor github.com/gardener/machine-controller-manager@v0.52.0 to adopt the above-mentioned fix. Along the way I had to bump github.com/gardener/gardener to at least v1.76.0 to make make revendor happy.

Which issue(s) this PR fixes:
Needed for subtask in gardener/gardener-extension-registry-cache#3

Special notes for your reviewer:
N/A

Release note:

The following dependencies are updated:
- github.com/gardener/gardener: v1.48.4 -> v1.76.0
- github.com/gardener/machine-controller-manager: v0.49.3 -> v0.52.0

@gardener-robot gardener-robot added kind/enhancement Enhancement, improvement, extension needs/review Needs review size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Mar 14, 2024
@ialidzhikov ialidzhikov force-pushed the machine-controller-manager@v0.52.0 branch from 211564a to 98de450 Compare March 14, 2024 12:46
@ialidzhikov ialidzhikov marked this pull request as ready for review March 14, 2024 13:53
@ialidzhikov ialidzhikov requested review from rfranzke and rishabh-11 and removed request for rfranzke April 9, 2024 09:04
Copy link
Contributor

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this task!

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Apr 9, 2024
@ialidzhikov ialidzhikov merged commit aa28b3a into gardener-attic:master Apr 10, 2024
5 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Apr 10, 2024
@ialidzhikov ialidzhikov deleted the machine-controller-manager@v0.52.0 branch April 10, 2024 05:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement Enhancement, improvement, extension reviewed/lgtm Has approval for merging size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants