Skip to content
This repository has been archived by the owner on Apr 7, 2020. It is now read-only.

Implement alicloud infrastructure controller #85

Merged
merged 2 commits into from
May 27, 2019
Merged

Implement alicloud infrastructure controller #85

merged 2 commits into from
May 27, 2019

Conversation

adracus
Copy link
Contributor

@adracus adracus commented May 14, 2019

What this PR does / why we need it:
Implementation of the infrastructure controller for Alicloud.
This PR also comes with some interfaces that allow mocking external dependencies such as the Terraformer and the creation of it.

Which issue(s) this PR fixes:
Fixes #26

Special notes for your reviewer:

Release note:

There is now an implementation of the infrastructure resource for Alicloud.

@adracus adracus added area/scalability Scalability (anything requiring static/dynamic scale up/down and/or out/in) related component/gardener Gardener exp/intermediate Issue that requires some project experience kind/enhancement Enhancement, improvement, extension needs/lgtm Needs approval for merging needs/review Needs review platform/ali priority/normal Standard backlog priority, that can be worked on now or later reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xl A few months of work or very large change (usually of epic proportions) status/in-progress Issue is in progress/work topology/seed Affects Seed clusters labels May 14, 2019
@adracus adracus requested a review from a team as a code owner May 14, 2019 09:08
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 14, 2019
@adracus adracus force-pushed the feature.infrastructure-alicloud branch from 8a9f2f6 to 898ea9a Compare May 15, 2019 11:05
@adracus adracus added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 15, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 15, 2019
stoyanr
stoyanr suggested changes May 16, 2019
View reviewed changes
controllers/provider-alicloud/pkg/alicloud/client/client.go Outdated Show resolved Hide resolved
controllers/provider-alicloud/pkg/alicloud/client/client.go Outdated Show resolved Hide resolved
controllers/provider-alicloud/pkg/alicloud/client/types.go Outdated Show resolved Hide resolved
controllers/provider-alicloud/pkg/alicloud/client/types.go Show resolved Hide resolved
controllers/provider-alicloud/pkg/controller/infrastructure/terraform.go Show resolved Hide resolved
pkg/gardener/chartrenderer/chartrenderer.go Outdated Show resolved Hide resolved
pkg/gardener/terraformer/terraformer.go Show resolved Hide resolved
pkg/gardener/terraformer/terraformer.go Outdated Show resolved Hide resolved
pkg/gardener/terraformer/terraformer.go Show resolved Hide resolved
@adracus adracus force-pushed the feature.infrastructure-alicloud branch from 898ea9a to 85a5331 Compare May 17, 2019 14:47
@CLAassistant
Copy link

CLAassistant commented May 17, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@adracus adracus force-pushed the feature.infrastructure-alicloud branch from 85a5331 to 51c2ab7 Compare May 17, 2019 14:50
@adracus adracus requested a review from stoyanr May 17, 2019 14:51
@adracus adracus added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 17, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 17, 2019
stoyanr
stoyanr reviewed May 20, 2019
View reviewed changes
Copy link
Contributor

@stoyanr stoyanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think some of the newly introduced types could be removed, others made simpler, without significant drawbacks. It's not a major point, so I am not going to insist if you don't feel comfortable with it, but I think it's worth a try.

@adracus adracus force-pushed the feature.infrastructure-alicloud branch from 51c2ab7 to 97d8849 Compare May 20, 2019 09:22
stoyanr
stoyanr previously approved these changes May 20, 2019
View reviewed changes
@adracus adracus added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 20, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 20, 2019
@rfranzke
Copy link
Contributor

rebase is needed now

@rfranzke
Copy link
Contributor

AFAIK you're busy with another task, so I'll try to finish this by pushing against your branch.

@adracus
Copy link
Contributor Author

adracus commented May 27, 2019

Alright, feel free to go ahead!

@rfranzke rfranzke force-pushed the feature.infrastructure-alicloud branch from 97d8849 to 46a52b9 Compare May 27, 2019 15:36
@rfranzke rfranzke added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 27, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 27, 2019
@rfranzke rfranzke merged commit faac970 into gardener-attic:master May 27, 2019
@ghost ghost added the platform/alicloud Alicloud platform/infrastructure label Mar 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stoyanr stoyanr stoyanr left review comments

@rfranzke rfranzke rfranzke requested changes

Assignees
No one assigned
Labels
area/scalability Scalability (anything requiring static/dynamic scale up/down and/or out/in) related component/gardener Gardener exp/intermediate Issue that requires some project experience kind/enhancement Enhancement, improvement, extension needs/lgtm Needs approval for merging needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review platform/alicloud Alicloud platform/infrastructure priority/normal Standard backlog priority, that can be worked on now or later size/xl A few months of work or very large change (usually of epic proportions) status/in-progress Issue is in progress/work topology/seed Affects Seed clusters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adracus @CLAassistant @rfranzke @stoyanr @gardener-robot-ci-1