This repository has been archived by the owner on Apr 7, 2020. It is now read-only.
Add GCP controlplane webhooks #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoyanr
force-pushed
the
add-gcp-controlplane-webhooks
branch
from
daeb4b7 to
e2245ef
Compare
rfranzke
added
the
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
adracus
approved these changes
May 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds controlplane webhooks for the GCP provider, including tests.
Special notes for your reviewer:
GetLoadBalancerIngresshas been copied from Gardener since its old version can't be used from webhooks (they don't get*rest.Configinjected), and the dependency on Gardener can't be updated (due to the controller runtime version). There is a TODO to remove it when the dependency to Gardener is finally updated.Release note: