Skip to content
This repository has been archived by the owner on Apr 7, 2020. It is now read-only.

Packet provider #78

Merged
merged 1 commit into from
May 13, 2019
Merged

Conversation

rfranzke
Copy link
Contributor

@rfranzke rfranzke commented May 8, 2019

What this PR does / why we need it:
Adds infrastructure and control plane controller for Packet provider.

Also, it simplifies some parts of the control plane actuators of AWS and GCP.

Special notes for your reviewer:
Based on gardener/gardener#916.
The control plane controller implements the CCM deployment. Based on how gardener/gardener#916 will continue I will add CSI deployment and possibly webhooks later.

Release note:

Added Packet infrastructure controller

@rfranzke rfranzke requested a review from stoyanr May 8, 2019 15:05
@rfranzke rfranzke requested a review from a team as a code owner May 8, 2019 15:05
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 8, 2019
Copy link
Contributor

@adracus adracus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still WIP?
Please make sure to remove unrelated changes from this changeset.

@rfranzke rfranzke force-pushed the feature/packet-infra branch from af62ba6 to ff5c0ce Compare May 8, 2019 17:05
@rfranzke rfranzke added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 8, 2019
@rfranzke rfranzke requested review from adracus and removed request for stoyanr May 8, 2019 17:05
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 8, 2019
@rfranzke
Copy link
Contributor Author

Any more feedback?

Copy link
Contributor

@adracus adracus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke merged commit 6efcc98 into gardener-attic:master May 13, 2019
@rfranzke rfranzke deleted the feature/packet-infra branch May 13, 2019 16:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants