This repository has been archived by the owner on Apr 7, 2020. It is now read-only.
Refactor controlplane controllers to eliminate code duplication #76
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Refactors the AWS and GCP controlplane actuators into a generic actuator and provider-specific "value providers" in order to eliminate code duplication.
Special notes for your reviewer:
Actuator
interface. Providers might choose to use the generic actuator and plug into it aValuesProvider
implementation, or they might choose to provide their ownActuator
if they need to do something different from the flow that the generic actuator implements.ValuesProvider
have been added.Release note: