Skip to content
This repository has been archived by the owner on Apr 7, 2020. It is now read-only.

Add kubelet config to AWS controlplane webhook #63

Conversation

stoyanr
Copy link
Contributor

@stoyanr stoyanr commented Apr 23, 2019

What this PR does / why we need it:
Adds additional logic for mutating kubelet configuration in OperatingSystemConfig resources to the AWS controlplane webhook.

Special notes for your reviewer:
Reusable types and functions are added to pkg/webhook/controlplane so that they could be used by other controlplane webhooks as well.

Release note:

Add kubelet config to AWS controlplane webhook

@stoyanr stoyanr requested a review from a team as a code owner April 23, 2019 13:59
@stoyanr stoyanr force-pushed the add-kubelet-config-aws-controlplane-webhook branch from f23fa2d to b5c6764 Compare April 23, 2019 15:39
pkg/webhook/controlplane/kubeletconfigcodec.go Outdated Show resolved Hide resolved
pkg/webhook/controlplane/kubeletconfigcodec.go Outdated Show resolved Hide resolved
pkg/webhook/controlplane/kubeletconfigcodec.go Outdated Show resolved Hide resolved
pkg/webhook/controlplane/utils.go Show resolved Hide resolved
@stoyanr stoyanr force-pushed the add-kubelet-config-aws-controlplane-webhook branch from b5c6764 to 6d2fc82 Compare April 24, 2019 12:28
@rfranzke rfranzke added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 24, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 24, 2019
Copy link
Contributor

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke requested a review from adracus April 24, 2019 14:11
@rfranzke rfranzke merged commit 4fa0160 into gardener-attic:master Apr 25, 2019
@stoyanr stoyanr deleted the add-kubelet-config-aws-controlplane-webhook branch April 30, 2019 08:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants