This repository has been archived by the owner on Apr 7, 2020. It is now read-only.
Enhance health check actuator with precheck function #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test
This was referenced Mar 22, 2020
timuthy
reviewed
Mar 23, 2020
rfranzke
force-pushed
the
enhance/health-checks
branch
from
1354c49 to
bd8ce80
Compare
gardener-robot-ci-1
added
reviewed/ok-to-test
|
@rfranzke can you specify in what conditions is this needed, I can think of non-gardener setups that use some extensions (for testing), what else? |
timuthy
previously approved these changes
Mar 23, 2020
ialidzhikov
reviewed
Mar 23, 2020
rfranzke
force-pushed
the
enhance/health-checks
branch
from
bd8ce80 to
85a0162
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
danielfoehrKn
approved these changes
Mar 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
With this PR the generic health check actuator is enhanced. It can now take a pre-check function that is performed before the health check is executed. If it returns false then the health check will be skipped. This accommodates extensions that only want to perform their health checks conditionally based on the object's or the cluster's settings.
Release note: