This repository has been archived by the owner on Apr 7, 2020. It is now read-only.
Use in-cluster shoot API-server urls for health-checks #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
ialidzhikov
reviewed
Feb 19, 2020
20 tasks
rfranzke
suggested changes
Feb 19, 2020
zanetworker
force-pushed
the
enhance/incluster-healthchecks
branch
from
e3b2291 to
9814705
Compare
gardener-robot-ci-3
added
reviewed/ok-to-test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently the internal DNS entry for the Shoot API-servers is used for health-checks, these health-cheks translate to egress traffic costs.
In an effort to optimize costs, this PR replaces the secret used for the kubeconfig of the seed cluster with another that makes use of an in-cluster url similar to gardener/gardener#1928
Which issue(s) this PR fixes:
Part of #gardener/gardener#1953
Special notes for your reviewer:
Release note: