This repository has been archived by the owner on Apr 7, 2020. It is now read-only.
Add controlplane webhooks tests #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfranzke
added
the
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
stoyanr
force-pushed
the
add-controlplane-webhooks-tests
branch
from
d70b6cf to
65fed02
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds tests for the generic part of controlplane webhooks introduced with #48.
Special notes for your reviewer:
In addition to adding tests, moved some code from
pkg/controller/cmd/options_test.gotopkg/util/test/options.goso that it could be used frompkg/webhook/cmd/options_test.go.Release note: