This repository has been archived by the owner on Apr 7, 2020. It is now read-only.
Make validator AWS support all offered core shoot versions #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-1
added
reviewed/ok-to-test
timuthy
force-pushed
the
enhancement.validator-aws
branch
from
48bf113 to
63c8e76
Compare
gardener-robot-ci-2
added
reviewed/ok-to-test
timuthy
force-pushed
the
enhancement.validator-aws
branch
from
63c8e76 to
ee2f42b
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Previously, the
validator-awsonly supportedv1beta1.shoots.core.gardener.cloudwhich is not sufficient because Gardener also offeres av1alpha1version. The validator now works with the internal shoot version, so that validation for all offered external versions are covered out of the box.Special notes for your reviewer:
The
Validatingwebhookconfigurationforgardener-extensions-validator-awsnow also requires a minimum Kubernetes version of 1.15.x. because of the introducedobjectSelectorfield.Gardener version
v0.34.0will rely on the k8s code base1.16.0which on the other hand can't dispatch admission requests for webhook configurations w/o anobjectSelector.See: kubernetes/kubernetes#78505
Release note: