Skip to content
This repository has been archived by the owner on Apr 7, 2020. It is now read-only.

Implement AWS controlplane webhooks #52

Merged
merged 1 commit into from
Apr 17, 2019
Merged

Implement AWS controlplane webhooks #52

merged 1 commit into from
Apr 17, 2019

Conversation

stoyanr
Copy link
Contributor

@stoyanr stoyanr commented Apr 12, 2019

What this PR does / why we need it:
Adds the actual implementation of AWS controlplane webhooks.

Special notes for your reviewer:
Based on #48, which should be merged first. Tests will follow in another PR.

Release note:

Implement AWS controlplane webhooks

@stoyanr stoyanr requested a review from a team as a code owner April 12, 2019 15:35
@stoyanr stoyanr force-pushed the implement-aws-controlplane-webhooks branch from 91039ca to d6dc892 Compare April 13, 2019 17:07
@stoyanr stoyanr mentioned this pull request Apr 15, 2019
Merged
@rfranzke rfranzke added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 15, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 15, 2019
@stoyanr stoyanr force-pushed the implement-aws-controlplane-webhooks branch 3 times, most recently from 7fd6412 to e4b6691 Compare April 15, 2019 15:17
@rfranzke rfranzke added area/control-plane Control Plane related (how to scale control-plane components) exp/intermediate Issue that requires some project experience kind/enhancement Enhancement, improvement, extension needs/rebase Needs git rebase needs/review Needs review platform/aws Amazon Web Services (AWS) platform/infrastructure priority/normal Standard backlog priority, that can be worked on now or later size/m A few days of work or medium change status/author-action Issue requires author action status/in-progress Issue is in progress/work status/under-investigation Issue is under investigation topology/seed Affects Seed clusters labels Apr 16, 2019
@stoyanr stoyanr force-pushed the implement-aws-controlplane-webhooks branch from e4b6691 to b58581f Compare April 16, 2019 07:41
@rfranzke rfranzke added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/rebase Needs git rebase labels Apr 16, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 16, 2019
@stoyanr stoyanr force-pushed the implement-aws-controlplane-webhooks branch from b58581f to 8e12a50 Compare April 16, 2019 10:31
@rfranzke rfranzke mentioned this pull request Apr 16, 2019
Closed
17 tasks
timuthy
timuthy approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

rfranzke
rfranzke approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging status/accepted Issue was accepted as something we need to work on and removed needs/review Needs review status/author-action Issue requires author action status/in-progress Issue is in progress/work status/under-investigation Issue is under investigation labels Apr 17, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 17, 2019
@rfranzke rfranzke removed the needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 17, 2019
@rfranzke rfranzke merged commit 04f436d into gardener-attic:master Apr 17, 2019
@stoyanr stoyanr deleted the implement-aws-controlplane-webhooks branch April 17, 2019 16:05
rfranzke added a commit that referenced this pull request Jan 14, 2020
@rfranzke
Upgrade github.com/gardener/external-dns-management
ce99d1d 
from v0.7.3 to v0.7.4

Follow-up of #547

``` improvement operator github.com/gardener/external-dns-management #52 @MartinWeindel
DNS entry with empty target is recognised as invalid.
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timuthy timuthy timuthy approved these changes

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
area/control-plane Control Plane related (how to scale control-plane components) exp/intermediate Issue that requires some project experience kind/enhancement Enhancement, improvement, extension platform/aws Amazon Web Services (AWS) platform/infrastructure priority/normal Standard backlog priority, that can be worked on now or later reviewed/lgtm Has approval for merging size/m A few days of work or medium change status/accepted Issue was accepted as something we need to work on topology/seed Affects Seed clusters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stoyanr @rfranzke @timuthy @gardener-robot-ci-1