This repository has been archived by the owner on Apr 7, 2020. It is now read-only.
make customized image optional and add error message #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test
|
Related to #427. |
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
gardener-robot-ci-1
added
reviewed/ok-to-test
ialidzhikov
reviewed
Dec 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Now by default no dummy secret will be created for extension-provider-alicloud in extension's namespace unless explicitly configured. Also fix the problem that when the secret is missing Alicloud ECS client will still be instantiated.
Error message is added as well when customized image sharing is not enabled/configured correctly and image is shared.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: