initial health check library implementation #472

danielfoehrKn · 2019-11-29T16:37:49Z

Includes the health check library implementation & the integration into all providers.
Integration tests are tracked in #466
What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #406

Special notes for your reviewer:

Release note:

extension providers write health check conditions into extension resources. Extensions can contribute to the Health of the Shoot. The gardener watches conditions with type SystemComponentsHealthy, EveryNodeReady, ControlPlaneHealthy on the extension resource.

rfranzke · 2019-12-05T09:48:35Z

Unfortunately, my review can't be submitted (too large, GitHub timeout; opened an issue and they know about it but can't fix it now). Sent you the review via email.

ialidzhikov

Minor nit to make the ci/cd happy.

pkg/controller/controlplane/genericactuator/gomock_reflect_413463832/prog.go

pkg/mock/controller-runtime/manager/gomock_reflect_754084279/prog.go

danielfoehrKn · 2019-12-30T15:57:55Z

I would like to get this in soon as I am constantly having to rebase.
Can someone take a look/review?

rfranzke · 2019-12-30T16:44:03Z

I was waiting for your feedback on your tests. My last level of information was that you want to test all the controllers e2e with Gardener (actually, with a modified Gardener that does no longer check the health of certain components on its own (like mcm or ccm, etc.)).

controllers/extension-shoot-dns-service/pkg/cmd/options.go

controllers/extension-shoot-dns-service/pkg/controller/config/config.go

controllers/provider-alicloud/hack/generate-code

controllers/provider-alicloud/pkg/alicloud/types.go

controllers/provider-aws/pkg/controller/worker/actuator.go

controllers/provider-openstack/cmd/gardener-extension-provider-openstack/app/app.go

docs/healthcheck-library.md

pkg/controller/healthcheck/general/statefulsets.go

go.mod

pkg/controller/healthcheck/general/daemonset.go

ialidzhikov · 2020-01-03T11:08:34Z

pkg/controller/healthcheck/general/deployment.go

+	deployment := &v1.Deployment{}
+
+	var err error
+	if healthChecker.checkType == DeploymentCheckTypeSeed {


Can't we just accept the client as func arg?

this would mean that the user has to pass in the client. As we only have two options, I do not really see a reason to do that, but would rather hide that 'complexity'

pkg/controller/healthcheck/general/deployment.go

pkg/controller/healthcheck/general/managed_resource.go

pkg/controller/healthcheck/worker/sufficient_nodes.go

danielfoehrKn · 2020-01-08T17:05:59Z

Checked working on all major providers.
Also checked working together with Gardener PR

ialidzhikov · 2020-01-08T18:07:44Z

Could you please check the ci/cd?

rfranzke · 2020-01-10T08:03:23Z

Thanks for your thorough testing. After CI passes I'm okay with merging the PR 👍

controllers/provider-alicloud/test/tm/generator.go

…ensions

…enlet care controller

rfranzke · 2020-01-10T14:31:03Z

/lgtm (can't approve because I have a pending review with 91 comments from my first review that GitHub can't handle (times out))

danielfoehrKn requested a review from a team as a code owner November 29, 2019 16:37

danielfoehrKn force-pushed the extension-health-checks branch from 1c9b2b7 to bb20ec7 Compare November 30, 2019 19:55

gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 30, 2019

gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 30, 2019

gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 3, 2019

danielfoehrKn mentioned this pull request Dec 3, 2019

adding health check library documentation gardener/gardener#1682

Merged

vpnachev mentioned this pull request Dec 10, 2019

Remove health check for calico typha gardener/gardener#1712

Merged

danielfoehrKn force-pushed the extension-health-checks branch from 591f547 to 3fb8e91 Compare December 16, 2019 16:14

gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 16, 2019

gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 16, 2019

gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 16, 2019

gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 16, 2019

danielfoehrKn force-pushed the extension-health-checks branch from 183f05a to bc85b90 Compare December 16, 2019 16:45

gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 16, 2019

rfranzke added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 17, 2019

gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 17, 2019

ialidzhikov reviewed Dec 17, 2019

View reviewed changes

pkg/controller/controlplane/genericactuator/gomock_reflect_413463832/prog.go Outdated Show resolved Hide resolved

pkg/mock/controller-runtime/manager/gomock_reflect_754084279/prog.go Outdated Show resolved Hide resolved

danielfoehrKn force-pushed the extension-health-checks branch from bc85b90 to f8d39c8 Compare December 17, 2019 08:43

gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 17, 2019

gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 17, 2019

danielfoehrKn force-pushed the extension-health-checks branch from f8d39c8 to f96b9a4 Compare December 19, 2019 15:43

gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 19, 2019

gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 19, 2019

danielfoehrKn force-pushed the extension-health-checks branch from f96b9a4 to ed25cac Compare December 19, 2019 16:48

gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 30, 2019

ialidzhikov reviewed Jan 2, 2020

View reviewed changes

ialidzhikov reviewed Jan 3, 2020

View reviewed changes

gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 8, 2020

gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 8, 2020

danielfoehrKn mentioned this pull request Jan 8, 2020

Cleaning care controller in gardenlet gardener/gardener#1786

Merged

danielfoehrKn force-pushed the extension-health-checks branch from c0f5e9c to 4b1a78d Compare January 8, 2020 17:03

gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 8, 2020

danielfoehrKn force-pushed the extension-health-checks branch from 4b1a78d to bceb2f2 Compare January 10, 2020 09:37

gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 10, 2020

gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 10, 2020

ialidzhikov reviewed Jan 10, 2020

View reviewed changes

controllers/provider-alicloud/test/tm/generator.go Show resolved Hide resolved

danielfoehrKn added 5 commits January 10, 2020 12:10

initial health check library implementation + integration for all ext…

975b8c3

…ensions

sorting all imports

245b370

adapting health check library to v1beta1

361b308

cleaning machinesets in worker controller. Previously located in gard…

4811b6f

…enlet care controller

adjust healthcheck helpers to be able to check in the shoot and the seed

ea54c2d

danielfoehrKn force-pushed the extension-health-checks branch from bceb2f2 to ea54c2d Compare January 10, 2020 11:14

gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 10, 2020

rfranzke merged commit 1979fd9 into gardener-attic:master Jan 10, 2020

danielfoehrKn deleted the extension-health-checks branch January 10, 2020 14:45

rfranzke mentioned this pull request Jan 14, 2020

Fix issue in cp ctrl that sometimes preserved last error #542

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

initial health check library implementation #472

initial health check library implementation #472

danielfoehrKn commented Nov 29, 2019 •

edited

Loading

rfranzke commented Dec 5, 2019

ialidzhikov left a comment

danielfoehrKn commented Dec 30, 2019

rfranzke commented Dec 30, 2019

ialidzhikov Jan 3, 2020

danielfoehrKn Jan 10, 2020

danielfoehrKn commented Jan 8, 2020

ialidzhikov commented Jan 8, 2020

rfranzke commented Jan 10, 2020

rfranzke commented Jan 10, 2020 •

edited

Loading

initial health check library implementation #472

initial health check library implementation #472

Conversation

danielfoehrKn commented Nov 29, 2019 • edited Loading

rfranzke commented Dec 5, 2019

ialidzhikov left a comment

Choose a reason for hiding this comment

danielfoehrKn commented Dec 30, 2019

rfranzke commented Dec 30, 2019

ialidzhikov Jan 3, 2020

Choose a reason for hiding this comment

danielfoehrKn Jan 10, 2020

Choose a reason for hiding this comment

danielfoehrKn commented Jan 8, 2020

ialidzhikov commented Jan 8, 2020

rfranzke commented Jan 10, 2020

rfranzke commented Jan 10, 2020 • edited Loading

danielfoehrKn commented Nov 29, 2019 •

edited

Loading

rfranzke commented Jan 10, 2020 •

edited

Loading