Skip to content
This repository has been archived by the owner on Apr 7, 2020. It is now read-only.

Added OpenStack Provider #45

Merged
merged 11 commits into from
Apr 18, 2019
Merged

Added OpenStack Provider #45

merged 11 commits into from
Apr 18, 2019

Conversation

afritzler
Copy link
Contributor

@afritzler afritzler commented Apr 9, 2019 •
edited
Loading

What this PR does / why we need it:
Added OpenStack provider support.

Which issue(s) this PR fixes:
Fixes #25

Special notes for your reviewer:

Release note:

The OpenStack provider does now have support for the `Infrastructure` extension.

@afritzler afritzler requested a review from a team as a code owner April 9, 2019 12:58
@rfranzke rfranzke added area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related exp/intermediate Issue that requires some project experience kind/enhancement Enhancement, improvement, extension needs/review Needs review platform/openstack OpenStack platform/infrastructure priority/normal Standard backlog priority, that can be worked on now or later reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xl A few months of work or very large change (usually of epic proportions) status/in-progress Issue is in progress/work status/under-investigation Issue is under investigation topology/seed Affects Seed clusters labels Apr 9, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 9, 2019
@rfranzke rfranzke added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 9, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 9, 2019
@rfranzke rfranzke added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 10, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 10, 2019
rfranzke
rfranzke suggested changes Apr 10, 2019
View reviewed changes
controllers/provider-openstack/charts/internal/openstack-infra/templates/_main.tf Outdated Show resolved Hide resolved
controllers/provider-openstack/charts/internal/openstack-infra/values.yaml Outdated Show resolved Hide resolved
controllers/provider-openstack/pkg/apis/openstack/install/install.go Outdated Show resolved Hide resolved
controllers/provider-openstack/pkg/apis/openstack/types_infrastructure.go Show resolved Hide resolved
controllers/provider-openstack/pkg/apis/openstack/types_infrastructure.go Outdated Show resolved Hide resolved
controllers/provider-openstack/pkg/apis/openstack/v1alpha1/types_infrastructure.go Outdated Show resolved Hide resolved
controllers/provider-openstack/pkg/controller/infrastructure/actuator_delete.go Outdated Show resolved Hide resolved
@AndreasBurger AndreasBurger added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 10, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 10, 2019
@rfranzke rfranzke added needs/changes Needs (more) changes status/author-action Issue requires author action needs/rebase Needs git rebase and removed needs/review Needs review status/in-progress Issue is in progress/work status/under-investigation Issue is under investigation labels Apr 11, 2019
@rfranzke rfranzke added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 16, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 16, 2019
@afritzler
Copy link
Contributor Author

The first working version is finished now. What is still missing are tests for the terraform part.

@afritzler
Copy link
Contributor Author

Some basic testing has now been added to the terraform chart redering logic.

@rfranzke rfranzke changed the title [WIP] Added OpenStack Provider Added OpenStack Provider Apr 18, 2019
@rfranzke rfranzke added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/changes Needs (more) changes needs/rebase Needs git rebase status/author-action Issue requires author action labels Apr 18, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 18, 2019
@rfranzke rfranzke added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 18, 2019
rfranzke
rfranzke approved these changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 18, 2019
@rfranzke rfranzke merged commit d5b20af into gardener-attic:master Apr 18, 2019
@afritzler afritzler deleted the feature.openstack_support branch April 18, 2019 14:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related exp/intermediate Issue that requires some project experience kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/openstack OpenStack platform/infrastructure priority/normal Standard backlog priority, that can be worked on now or later size/xl A few months of work or very large change (usually of epic proportions) topology/seed Affects Seed clusters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Infrastructure controller for OpenStack provider
4 participants
@afritzler @rfranzke @AndreasBurger @gardener-robot-ci-1