This repository has been archived by the owner on Apr 7, 2020. It is now read-only.
Black list SCTP protocol for alicloud (CVE-2019-3874) #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marwinski , I did a test with your configuration and sctp.conf is written successfully. Do we need a further test? |
rfranzke
suggested changes
Mar 28, 2019
controllers/os-coreos-alicloud/pkg/coreos-alicloud/actuator_reconcile.go
Outdated
Show resolved
Hide resolved
marwinski
force-pushed
the
blacklist-sctp-coreos-alicloud
branch
from
a67413c to
781aa4b
Compare
rfranzke
added
the
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
rfranzke
added
area/security
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
DO NOT SUBMIT, NOT TESTED
This PR is a workaround for CVE-2019-3874. It disables the PCTP protocol on all nodes.
Which issue(s) this PR fixes:
Special notes for your reviewer:
This is not yet tested due to the lack of testing environment for Alicloud (or failure to set up a working environment). It was migrated from #33 which tested ok.
Release note: