Skip to content
This repository has been archived by the owner on Apr 7, 2020. It is now read-only.

Ensure Cloud provider config as part of kubelet configuration #147

Merged
merged 1 commit into from
Jun 18, 2019
Merged

Ensure Cloud provider config as part of kubelet configuration #147

merged 1 commit into from
Jun 18, 2019

Conversation

svetlinas
Copy link
Contributor

@svetlinas svetlinas commented Jun 14, 2019 •
edited
Loading

What this PR does / why we need it:

  • Ensure Kubelet Service unit option ExecStartPre (CloudConfigUserDataConfig.HostnameOverride)
  • Ensure Cloud provider config as part of kubelet configuration

Special notes for your reviewer:

Release note:

Issues related to Openstack and Azure extension controller

@svetlinas svetlinas requested a review from stoyanr as a code owner June 14, 2019 12:35
@svetlinas svetlinas force-pushed the fix-openstack-extension branch 3 times, most recently from f3fd8d6 to 0c4495b Compare June 17, 2019 12:38
@svetlinas svetlinas force-pushed the fix-openstack-extension branch 3 times, most recently from c5a058e to 7b06c2c Compare June 18, 2019 07:12
@svetlinas svetlinas changed the title [WIP] Issues related to Openstack extension controller Ensure Cloud provider config as part of kubelet configuration Jun 18, 2019
@rfranzke rfranzke added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 18, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 18, 2019
@svetlinas svetlinas force-pushed the fix-openstack-extension branch from 7b06c2c to f49f04d Compare June 18, 2019 07:54
@svetlinas svetlinas force-pushed the fix-openstack-extension branch from f49f04d to 051d7d4 Compare June 18, 2019 08:05
@rfranzke rfranzke added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 18, 2019
rfranzke
rfranzke approved these changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke merged commit 9f892bc into gardener-attic:master Jun 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stoyanr stoyanr stoyanr requested changes

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@svetlinas @stoyanr @rfranzke @gardener-robot-ci-1