Skip to content
This repository has been archived by the owner on Apr 7, 2020. It is now read-only.

Fix alicloud's status units and command #13

Merged
merged 1 commit into from
Feb 25, 2019
Merged

Fix alicloud's status units and command #13

merged 1 commit into from
Feb 25, 2019

Conversation

adracus
Copy link
Contributor

@adracus adracus commented Feb 25, 2019 •
edited by rfranzke
Loading

What this PR does / why we need it:
Enable .status.units and status.command for aliclouds operating system config resource.

Release note:

The `os-coreos-alicloud` controller does now correctly set the `.status.units` and `.status.command` fields in the `OperatingSystemConfig` resource.

@adracus adracus requested a review from a team as a code owner February 25, 2019 14:58
@adracus adracus added area/quality Output qualification (tests, checks, scans, automation in general, etc.) related component/gardener Gardener exp/intermediate Issue that requires some project experience kind/bug Bug needs/lgtm Needs approval for merging needs/review Needs review platform/ali priority/normal Standard backlog priority, that can be worked on now or later reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs A few minutes of work or very small change (usually trivial or cosmetic) status/under-investigation Issue is under investigation status/in-progress Issue is in progress/work topology/seed Affects Seed clusters labels Feb 25, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 25, 2019
@rfranzke rfranzke added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 25, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 25, 2019
@rfranzke rfranzke added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 25, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 25, 2019
rfranzke
rfranzke approved these changes Feb 25, 2019
View reviewed changes
Copy link
Contributor

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging status/accepted Issue was accepted as something we need to work on and removed needs/lgtm Needs approval for merging needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 25, 2019
@rfranzke rfranzke removed needs/review Needs review status/in-progress Issue is in progress/work status/under-investigation Issue is under investigation labels Feb 25, 2019
@rfranzke rfranzke merged commit 98982b7 into master Feb 25, 2019
@rfranzke rfranzke deleted the fix.alicloud-units branch February 25, 2019 18:18
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 25, 2019
@ghost ghost added the platform/alicloud Alicloud platform/infrastructure label Mar 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related component/gardener Gardener exp/intermediate Issue that requires some project experience kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/alicloud Alicloud platform/infrastructure priority/normal Standard backlog priority, that can be worked on now or later reviewed/lgtm Has approval for merging size/xs A few minutes of work or very small change (usually trivial or cosmetic) status/accepted Issue was accepted as something we need to work on topology/seed Affects Seed clusters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adracus @rfranzke @gardener-robot-ci-1