Skip to content
This repository has been archived by the owner on Apr 7, 2020. It is now read-only.

Temporarily disable writing to shoot in controlplane controllers #108

Merged

Conversation

stoyanr
Copy link
Contributor

@stoyanr stoyanr commented Jun 9, 2019

What this PR does / why we need it:
Temporarily disables writing to shoot in controlplane controllers to resolve ordering issue in Gardener flow.

Special notes for your reviewer:

Release note:

Temporarily disable writing to shoot in controlplane controllers

@stoyanr stoyanr requested a review from a team as a code owner June 9, 2019 15:02
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 9, 2019
@rfranzke
Copy link
Contributor

#107 is merged now. Could you rebase this one?

@stoyanr stoyanr force-pushed the fix-controlplane-controllers branch from 7e1957f to 6f4a60c Compare June 11, 2019 08:50
@rfranzke rfranzke added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 11, 2019
Copy link
Contributor

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 11, 2019
@rfranzke rfranzke merged commit 6976b19 into gardener-attic:master Jun 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants