Skip to content
This repository has been archived by the owner on Apr 7, 2020. It is now read-only.

Add controlplane webhooks for Openstack #105

Merged
merged 1 commit into from
Jun 11, 2019

Conversation

svetlinas
Copy link
Contributor

What this PR does / why we need it:
Adds controlplane webhooks for Openstack

Which issue(s) this PR fixes:
Fixes #56

Special notes for your reviewer:
Completes controlplane controller implementation for the Openstack provider. (PR #97)

Release note:

Add controlplane webhooks for Openstack

@svetlinas svetlinas requested a review from a team as a code owner June 6, 2019 15:17
@svetlinas svetlinas force-pushed the add-openstack-webhooks branch 2 times, most recently from ad4f555 to 89fb237 Compare June 7, 2019 10:43
@svetlinas svetlinas changed the title [WIP] Add controlplane webhooks for Openstack Add controlplane webhooks for Openstack Jun 7, 2019
@svetlinas svetlinas force-pushed the add-openstack-webhooks branch from 89fb237 to 76b0479 Compare June 7, 2019 12:15
@rfranzke rfranzke added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 8, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 8, 2019
@svetlinas svetlinas force-pushed the add-openstack-webhooks branch from 76b0479 to 23b2755 Compare June 10, 2019 07:19
@rfranzke rfranzke added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 11, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 11, 2019
Copy link
Contributor

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke merged commit 1ef9033 into gardener-attic:master Jun 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement ControlPlane controller for OpenStack provider
3 participants