This repository has been archived by the owner on Apr 7, 2020. It is now read-only.
Skip Cert-Broker when DNS provider is unmanaged #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timuthy
added
kind/bug
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
timuthy
added
reviewed/ok-to-test
timuthy
force-pushed
the
fix/certificate-service
branch
from
11d792a to
2b16711
Compare
gardener-robot-ci-1
added
needs/ok-to-test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes an issue for the
Certificate-Serviceextension controller when thedomainof a shoot is nil. This is a valid scenario if the shoot's dns provider isunmanaged. Hence, the extension controller can omit the deployment ofCert-Broker.Release note: