Skip to content
This repository has been archived by the owner on Apr 7, 2020. It is now read-only.

Add Alicloud controlplane webhooks #101

Merged

Conversation

stoyanr
Copy link
Contributor

@stoyanr stoyanr commented Jun 4, 2019

What this PR does / why we need it:
Adds controlplane webhooks for Alicloud.

Which issue(s) this PR fixes:
Fixes #57

Special notes for your reviewer:
Depends on #98 which should be merged first.

Release note:

Add alicloud controlplane webhooks

@stoyanr stoyanr requested a review from a team as a code owner June 4, 2019 10:37
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 4, 2019
@stoyanr stoyanr changed the title Add alicloud controlplane webhooks Add Alicloud controlplane webhooks Jun 4, 2019
@stoyanr stoyanr force-pushed the add-alicloud-controlplane-webhooks branch from 3a1eaf8 to 4cfc54d Compare June 6, 2019 08:30
@rfranzke rfranzke added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 6, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 6, 2019
rfranzke
rfranzke previously approved these changes Jun 6, 2019
Copy link
Contributor

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm. Waiting for the alicloud control plane PR to be merged first.

@stoyanr stoyanr force-pushed the add-alicloud-controlplane-webhooks branch from 4cfc54d to e24ab96 Compare June 6, 2019 11:39
@rfranzke rfranzke added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 6, 2019
@rfranzke rfranzke merged commit 6c33121 into gardener-attic:master Jun 6, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 6, 2019
@stoyanr stoyanr deleted the add-alicloud-controlplane-webhooks branch June 6, 2019 12:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement ControlPlane controller for Alicloud provider
3 participants