Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix machine class chart #86

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Conversation

mfranczy
Copy link
Contributor

Signed-off-by: Marcin Franczyk marcin0franczyk@gmail.com

How to categorize this PR?

/area usability
/kind bug
/priority normal
/platform kubevirt

What this PR does / why we need it:
It fixes machine class chart.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

improvement_user

Signed-off-by: Marcin Franczyk <marcin0franczyk@gmail.com>
@mfranczy mfranczy requested a review from a team as a code owner October 14, 2020 09:49
@gardener-robot gardener-robot added area/usability Usability related kind/bug Bug platform/kubevirt Container Native Virtualization (CNV) KubeVirt platform/infrastructure priority/normal needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Oct 14, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 14, 2020
@mfranczy
Copy link
Contributor Author

/cc @stoyanr, during reviews I missed a bug in machine class, fixing it now.

@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 14, 2020
@gardener-robot gardener-robot removed the needs/review Needs review label Oct 14, 2020
@stoyanr stoyanr merged commit 9b60517 into gardener-attic:master Oct 14, 2020
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) needs/lgtm Needs approval for merging reviewed/lgtm Has approval for merging and removed priority/3 Priority (lower number equals higher priority) needs/lgtm Needs approval for merging labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/usability Usability related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/kubevirt Container Native Virtualization (CNV) KubeVirt platform/infrastructure reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants