This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
Ensure shell command pod names are lowercase #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-3
added
the
reviewed/ok-to-test
neo-liang-sap
approved these changes
May 14, 2021
gardener-robot-ci-2
added
needs/ok-to-test
|
thanks @stoyanr , per Slack conversation i will proceed with merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Ensures
shellcommand pod names conform to the pod name requirements by making sure the output ofwhoamiis lowercased.Which issue(s) this PR fixes:
Fixes #514
Special notes for your reviewer:
Release note: