Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

check whether ingress rule exist before adding it #494

Conversation

neo-liang-sap
Copy link
Contributor

What this PR does / why we need it:
Check whether ingress rule (from client ip with CIDR /32 and port 22) already exist in host security group before adding it
Which issue(s) this PR fixes:
Fixes #492

Special notes for your reviewer:

Release note:

Check whether ingress rule (from client ip with CIDR /32 and port 22) already exist in host security group before adding it

@neo-liang-sap neo-liang-sap requested a review from a team as a code owner December 10, 2020 01:38
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Dec 10, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 10, 2020
@tedteng tedteng mentioned this pull request Dec 17, 2020
@neo-liang-sap
Copy link
Contributor Author

/test

@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 14, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 14, 2021
@neo-liang-sap
Copy link
Contributor Author

This PR has been tested locally without problem and pending commenter's counter-sample since 2020-dec-17 - see #492 (comment)
Proceed with Merging
If there could be any counter-sample provided feel free open a defect against this PR

@neo-liang-sap neo-liang-sap merged commit 266d81d into gardener-attic:master May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS SSH - fails due to existing resource
4 participants