Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

Make logPodSeed use the current context #431

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Make logPodSeed use the current context #431

merged 1 commit into from
Nov 20, 2020

Conversation

jguipi
Copy link
Contributor

@jguipi jguipi commented Nov 6, 2020 •
edited
Loading

What this PR does / why we need it:

  • Remove useless flag on the logPodShoot function
  • Allow the gardenctl logs vpn-seed to use the current context

Which issue(s) this PR fixes:
Fixes #388

Special notes for your reviewer:

  • none

Release note:

- Remove useless flag on the `logPodShoot` function
- Allow the `gardenctl logs vpn-seed` to use the current context

@jguipi jguipi requested a review from a team as a code owner November 6, 2020 20:08
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 6, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 6, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 6, 2020
dansible
dansible suggested changes Nov 9, 2020
View reviewed changes
pkg/cmd/logs.go Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added needs/changes Needs (more) changes and removed needs/review Needs review labels Nov 9, 2020
@dansible dansible changed the title KC-388 Make logPodSeed use the current context Nov 10, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 10, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 10, 2020
petersutter
petersutter reviewed Nov 10, 2020
View reviewed changes
pkg/cmd/logs.go Outdated Show resolved Hide resolved
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 10, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 10, 2020
@jguipi
Remove useless flag, make logs vpn-seed use current context,
42c02e6 
remove bash dependancies on logsVpnSeed and fix current context output

typo

change the method to get current context
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 17, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 17, 2020
@jguipi jguipi merged commit ca31c4f into gardener-attic:master Nov 20, 2020
@jguipi jguipi deleted the kc-388 branch November 20, 2020 01:28
@neo-liang-sap neo-liang-sap mentioned this pull request Nov 20, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@petersutter petersutter petersutter left review comments

@tedteng tedteng tedteng left review comments

@dansible dansible dansible approved these changes

Assignees
No one assigned
Labels
needs/changes Needs (more) changes needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make logPodSeed use the current context
8 participants
@jguipi @petersutter @dansible @tedteng @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot