This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
fix gardenctl ssh alicloud node timed out issue #380
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
fix gardenctl ssh alicloud node timed out issue
Which issue(s) this PR fixes:
Fixes #379
Special notes for your reviewer:
Some explanation on this PR:
aliyun
cli to latestRules
will created. There are two cases which prevents ssh alicloud node success:a. the SG exist but no rules exist
b. the SG exist, rules exist but the SourceIPCidr in rules is incorrect
SourceIPCidr
,port
,protocol
,ingress/egress
won't causing multi records in SG, so the creation of rules is idempotentto
as previous code causing following error
Release note: