This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
refactor ssh_aws remove capture() #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-3
added
reviewed/ok-to-test
tedteng
force-pushed
the
remove_capture
branch
from
3b3864b
to
a86655e
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
tedteng
force-pushed
the
remove_capture
branch
from
a86655e
to
57a895c
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
tedteng
force-pushed
the
remove_capture
branch
from
57a895c
to
d5677ca
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
neo-liang-sap
approved these changes
Oct 12, 2020
There was a problem hiding this comment.
/LGTM
i haven't test it but based on author's testing here and CI testing i approve and merge this PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
refactor ssh feature to remove capture() and capturedOutput
Which issue(s) this PR fixes:
Fixes #354
Special notes for your reviewer:
Release note: