Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

check cloud provider cli whether installed on local env #300

Merged

Conversation

neo-liang-sap
Copy link
Contributor

What this PR does / why we need it:
add check whether cloud provider cli is installed on local env, if not, prompt error msg / how to install and exit gardenctl
Which issue(s) this PR fixes:
Fixes #299

Special notes for your reviewer:
@dansible
Release note:

add check whether cloud provider cli is installed on local env, if not, prompt error msg / how to install and exit gardenctl

@neo-liang-sap neo-liang-sap requested a review from a team as a code owner September 2, 2020 14:04
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 2, 2020
@neo-liang-sap
Copy link
Contributor Author

@dansible do you have any comments on this PR? thanks! -Neo

@dansible
Copy link
Contributor

dansible commented Sep 7, 2020

/lgtm 👍

@gardener-robot gardener-robot added the reviewed/lgtm Has approval for merging label Sep 7, 2020
@neo-liang-sap neo-liang-sap merged commit 0efeaa8 into gardener-attic:master Sep 8, 2020
@neo-liang-sap neo-liang-sap deleted the check-native-cloud-client branch September 8, 2020 00:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No error message when cloud client is not present
4 participants