This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
fix logic covering both garden+seed+shoot and garden+project+shoot #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test
|
the test covers following flow:
@Kristian-ZH i hope i'm understanding correctly on your issue, do let me know if i missed anything, thanks! |
|
Yup, this will resolve the issue. Thanks! |
petersutter
reviewed
Sep 2, 2020
| checkError(err) | ||
| var filteredShoots []gardencorev1beta1.Shoot | ||
| for _, s := range shootList.Items { | ||
| if s.Name == target.Stack()[2].Name { |
There was a problem hiding this comment.
@neo-liang-sap sorry for beeing late for the review, but here you are missing the check for the seed. Do not add to filteredShoots if the seed does not match the one on the target stack
There was a problem hiding this comment.
thanks! i added a new PR for this here
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
current operate.go only covers scenario when target stack is garden+project+shoot, should also cover scenario garden+seed+shoot
Which issue(s) this PR fixes:
Fixes #295
Special notes for your reviewer:
/CC @Kristian-ZH
Release note: