fix(k8s): ensure images built remotely are tagged before publishing #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix: A bug fix.
What this PR does / why we need it:
Publish command would fail for images built remotely since they will have different names than what's needed for the registry that's being published to. We might e.g. pull something like:
local.app.garden:53113/eysi-demo-project/backend:v-d8c8e24c77but need to push something like:eu.gcr.io/garden-dev-200012/backend:v-d8c8e24c77. This PR resolves that.Which issue(s) this PR fixes:
Fixes #960