-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc doc updates and refreshes #891
Conversation
Note: I dropped the FAQ in preference of the updated README, plus a bunch of it felt dated and irrelevant today. |
docs/basics/stack-graph.md
Outdated
|
||
Importantly, what happens within each of the actions that the graph describes—building, deploying, running etc.—is completely pluggable via the providers. The Stack Graph is only opinionated in terms of flows and dependencies—_what_ should happen _when_—but the _how_ is pluggable. | ||
|
||
All the Garden plugins are currently built-in, but we will soon release a plugin SDK to allow any user to easily make their |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion:
built-in, but we
↓
built-in; we
|
||
Here we only include the `Dockerfile` and all the `.py` files under `my-sources/`. | ||
|
||
`.gardenignore` do the opposite, which is to list all files/paths that you want to ignore. They work exactly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing word 'files':
.gardenignore
files do the opposite
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a missing word on docs/using-garden/configuration-files.md
that we should address now, otherwise LGTM, we can nitpick this later.
👍 thanks! |
375770c
to
363c8ea
Compare
363c8ea
to
a45a539
Compare
@ellenkorbes: Addressed your comments. Can you check and approve? |
LGTM |
a45a539
to
0a70a06
Compare
No description provided.