Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc doc updates and refreshes #891

Merged
merged 3 commits into from
Jun 27, 2019
Merged

Misc doc updates and refreshes #891

merged 3 commits into from
Jun 27, 2019

Conversation

edvald
Copy link
Collaborator

@edvald edvald commented Jun 27, 2019

No description provided.

@edvald edvald requested review from thsig and vkorbes and removed request for thsig June 27, 2019 08:59
@edvald
Copy link
Collaborator Author

edvald commented Jun 27, 2019

Note: I dropped the FAQ in preference of the updated README, plus a bunch of it felt dated and irrelevant today.


Importantly, what happens within each of the actions that the graph describes—building, deploying, running etc.—is completely pluggable via the providers. The Stack Graph is only opinionated in terms of flows and dependencies—_what_ should happen _when_—but the _how_ is pluggable.

All the Garden plugins are currently built-in, but we will soon release a plugin SDK to allow any user to easily make their
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:
built-in, but we

built-in; we


Here we only include the `Dockerfile` and all the `.py` files under `my-sources/`.

`.gardenignore` do the opposite, which is to list all files/paths that you want to ignore. They work exactly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing word 'files':

.gardenignore files do the opposite

Copy link
Contributor

@vkorbes vkorbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a missing word on docs/using-garden/configuration-files.md that we should address now, otherwise LGTM, we can nitpick this later.

@edvald
Copy link
Collaborator Author

edvald commented Jun 27, 2019

👍 thanks!

@edvald edvald removed the request for review from thsig June 27, 2019 09:47
@thsig thsig force-pushed the better-remote-init branch from 375770c to 363c8ea Compare June 27, 2019 11:17
@edvald edvald force-pushed the better-remote-init branch from 363c8ea to a45a539 Compare June 27, 2019 11:36
@edvald
Copy link
Collaborator Author

edvald commented Jun 27, 2019

@ellenkorbes: Addressed your comments. Can you check and approve?

@vkorbes
Copy link
Contributor

vkorbes commented Jun 27, 2019

LGTM

@edvald edvald force-pushed the better-remote-init branch from a45a539 to 0a70a06 Compare June 27, 2019 11:49
@edvald edvald changed the base branch from better-remote-init to master June 27, 2019 11:56
@thsig thsig merged commit 5c1efd6 into master Jun 27, 2019
@thsig thsig deleted the misc-docs branch June 27, 2019 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants