fix(k8s): don't store full version object with test+task results #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edvald
force-pushed
the
fix-run-result-storage-2
branch
from
6e1dbd7 to
05cbb10
Compare
10ko
reviewed
Jun 26, 2019
|
Tested and fixes my issues, even when running tests with |
This required some mechanism for plugins to expose commands. We should later iterate on that, but it's a start. The cleanup flow and command itself is described in the In-Cluster Building guide.
This addresses issues where the list of files, contained in the module version object, would push the size of the result ConfigMap over 1MB.
edvald
force-pushed
the
fix-run-result-storage-2
branch
from
05cbb10 to
c4e4059
Compare
|
@10ko fixed that line. Can you give a stamp of approval? :) |
thsig
approved these changes
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issues where the list of files, contained in the module
version object, would push the size of the result ConfigMap over 1MB.