fix(k8s): enable publishing container modules when using remote builders #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has the caveat that you need to have a local Docker daemon running. Avoiding that requirement would take much more work, since we'd need to tackle all manner of authentication/key management issues.
thsig
force-pushed
the
fix-remote-build-publish
branch
from
e8d3761 to
5cfeca2
Compare
thsig
approved these changes
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has the caveat that you need to have a local Docker daemon running.
Avoiding that requirement would take much more work, since we'd need to
tackle all manner of authentication/key management issues.