fix(core): chokidar watcher on mac could segfault after reloading config #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are hanging now after they run, because the watcher keeps running. Need to work out how to fix that. |
edvald
force-pushed
the
fix-watch-segfault
branch
from
71559ca to
c938073
Compare
…figs Turns out chokidar and the native fsevents module don't like it when multiple instances are created in a single process, even if one is closed before the other starts. Fixed it by making a global instance and reconfiguring on reload instead. See fsevents/fsevents#273 for a discussion on this issue.
edvald
force-pushed
the
fix-watch-segfault
branch
from
c938073 to
b950823
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out chokidar and the native fsevents module don't like it when multiple
instances are created in a single process, even if one is closed before the
other starts. Fixed it by making a global instance and reconfiguring on
reload instead. See fsevents/fsevents#273 for
a discussion on this issue.