fix: ensure CLI returns correct exit code (#626) #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thsig
requested changes
Mar 26, 2019
|
Looks good! Had one comment/thought about the docstring for the |
|
Since we're changing the flag, it's technically a breaking change. However, in the previous version the flag wasn't documented at all, the help text was simply: |
eysi09
force-pushed
the
cli-log-fixes
branch
2 times, most recently
from
6551240 to
5a7fe16
Compare
thsig
approved these changes
Mar 27, 2019
...also changed LoggerType from enum to union type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...also changed LoggerType from enum to union type